Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecating AppD name field and promoting title to required #928

Merged
merged 2 commits into from
May 30, 2023
Merged

Deprecating AppD name field and promoting title to required #928

merged 2 commits into from
May 30, 2023

Conversation

kriswest
Copy link
Contributor

@kriswest kriswest commented Mar 9, 2023

resolves #820

Updates the appD spec to deprecate the name field, drop the requirement for it and promote title to required instead.

Current spec to compare with preview: https://fdc3.finos.org/schemas/next/app-directory.html

@kriswest kriswest added app-directory deprecation Deprecating or removing features post deprecation labels Mar 9, 2023
@kriswest kriswest requested review from hughtroeger and a team March 9, 2023 18:53
@netlify
Copy link

netlify bot commented Mar 9, 2023 •
edited
Loading

✅ Deploy Preview for fdc3 canceled.

Name Link
🔨 Latest commit 4cc8072
🔍 Latest deploy log https://app.netlify.com/sites/fdc3/deploys/640a2bda6ecb3d0008fb5705

@kriswest kriswest added this to the 2.1 milestone Mar 9, 2023
@kriswest kriswest mentioned this pull request Mar 20, 2023
Closed
26 tasks
@kriswest
Copy link
Contributor Author

@greyseer256 this'll need your review before its merged

hughtroeger
hughtroeger approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@hughtroeger hughtroeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kriswest kriswest removed this from the 2.1 milestone May 17, 2023
@kriswest kriswest merged commit 55d7775 into master May 30, 2023
@kriswest kriswest deleted the kriswest/issue820 branch May 30, 2023 10:14
@bingenito bingenito mentioned this pull request Nov 6, 2023
Closed
18 tasks
@bingenito bingenito mentioned this pull request Feb 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughtroeger hughtroeger hughtroeger approved these changes

@mattjamieson mattjamieson mattjamieson approved these changes

Assignees
No one assigned
Labels
app-directory deprecation Deprecating or removing features post deprecation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate appD name field and make it optional
3 participants
@kriswest @mattjamieson @hughtroeger